Skip to content

Conversation

@ffgan
Copy link
Contributor

@ffgan ffgan commented Nov 17, 2025

Hi there

Recently, riscv64(rv64) has gained widespread adoption, and we might consider adding rv64 support to the current repository. Go has excellent support for rv64, so we only need minor modifications to achieve rv64 artifact builds.

I tried the CI in my fork by tagging my commit and running it, and the results show everything works normally.

For details, see https://github.com/ffgan/go-containerregistry/actions/runs/19417813913

One thing that needs special mention: the setup-go step in .github/workflows/release.yml needs to be upgraded to 1.24, otherwise it will report the following error:

 ⨯ release failed after 0s                  error=failed to get module path: exit status 1: go: go.mod requires go >= 1.24 (running go 1.21.13; GOTOOLCHAIN=local)

Since I haven't seen tests for architectures other than x86, such as s390x, I haven't added or run tests for rv64. However, I believe this should work normally. If the maintainers think testing on specific architectures is necessary, we can use docker+qemu to implement it. I'd be happy to implement that part, but that should be a matter for another PR.

So, if there are any questions about the above, feel free to @ me directly anytime. I'm happy to answer all questions.


Otehr Info
Co-authored by: [email protected];

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 53.05%. Comparing base (8b3c303) to head (fc1dabf).
⚠️ Report is 48 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (8b3c303) and HEAD (fc1dabf). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (8b3c303) HEAD (fc1dabf)
2 1
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2159       +/-   ##
===========================================
- Coverage   71.67%   53.05%   -18.63%     
===========================================
  Files         123      164       +41     
  Lines        9935    10940     +1005     
===========================================
- Hits         7121     5804     -1317     
- Misses       2115     4429     +2314     
- Partials      699      707        +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Subserial Subserial merged commit d1809c8 into google:main Nov 19, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants