Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there
Recently, riscv64(rv64) has gained widespread adoption, and we might consider adding rv64 support to the current repository. Go has excellent support for rv64, so we only need minor modifications to achieve rv64 artifact builds.
I tried the CI in my fork by tagging my commit and running it, and the results show everything works normally.
For details, see https://github.com/ffgan/go-containerregistry/actions/runs/19417813913
One thing that needs special mention: the
setup-gostep in.github/workflows/release.ymlneeds to be upgraded to 1.24, otherwise it will report the following error:Since I haven't seen tests for architectures other than x86, such as s390x, I haven't added or run tests for rv64. However, I believe this should work normally. If the maintainers think testing on specific architectures is necessary, we can use docker+qemu to implement it. I'd be happy to implement that part, but that should be a matter for another PR.
So, if there are any questions about the above, feel free to @ me directly anytime. I'm happy to answer all questions.
Otehr Info
Co-authored by: [email protected];