Skip to content

Fix ArgsEscaped lint directive #2137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Subserial merged 3 commits into from
Oct 2, 2025
Merged

Fix ArgsEscaped lint directive #2137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7879943
Fix lint directive
Subserial Oct 2, 2025
ad0706e
Remove redundant staticcheck call
Subserial Oct 2, 2025
ea030f0
Remove unused staticcheck install from presubmit
Subserial Oct 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions hack/presubmit.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,20 +20,9 @@ set -o pipefail

PROJECT_ROOT="$(cd "$(dirname "${BASH_SOURCE[0]}")/.." && pwd)"

# We can't install in the current directory without changing the current module.
TMP_DIR="$(mktemp -d)"
export PATH="${PATH}:${TMP_DIR}/bin"
export GOPATH="${TMP_DIR}"
pushd ${TMP_DIR}
trap popd EXIT
go install honnef.co/go/tools/cmd/staticcheck@latest
popd

pushd ${PROJECT_ROOT}
trap popd EXIT

staticcheck ./pkg/...

# Verify that all source files are correctly formatted.
find . -name "*.go" | grep -v vendor/ | xargs gofmt -d -e -l

Expand Down
2 changes: 1 addition & 1 deletion pkg/v1/daemon/image.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,7 +312,7 @@ func (i *image) computeImageConfig(config *specs.DockerOCIImageConfig) v1.Config
User: config.User,
Volumes: config.Volumes,
WorkingDir: config.WorkingDir,
//lint:ignore SA1019 this is erroneously deprecated, as windows uses it
//nolint:staticcheck // SA1019 this is erroneously deprecated, as windows uses it
ArgsEscaped: config.ArgsEscaped,
StopSignal: config.StopSignal,
Shell: config.Shell,
Expand Down
Loading