Skip to content

Conversation

@sherine-k
Copy link

This is my first PR to this repository.

This PR doesn't aim to fix #1200 (yet) : This is just an initial attempt to do so.

I'm submitting this in order to initiate the discussion started in #1200 around the implementation, and acknowledge that:

  • I wasn't able to successfully run ./hack/presubmit.sh: It complains about absence of cmp and cpu under the internal folder
  • I didn't implement any unit tests so far, but will do so after we validate together the direction for this PR
  • Some things are still hard coded, and I need to fix those things after getting a green light for continuing

Thanks for the opportunity, and looking forward to contributing

@mepi262
Copy link

mepi262 commented Nov 22, 2024

@jonjohnsonjr @mattmoor @imjasonh cc @sherine-k
The reviewee wants to discuss this pull request. With Whom is it appropriate to discuss it?

@github-actions
Copy link

This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Keep fresh with the 'lifecycle/frozen' label.

@deitch
Copy link
Collaborator

deitch commented Jul 2, 2025

This would be great to have. Got to be rebased, and have a maintainer review it.

@mepi262
Copy link

mepi262 commented Dec 9, 2025

@sherine-k
It seems that some checks are not working.
This stackoverflow may help you.
https://stackoverflow.com/questions/52200096/github-pull-request-waiting-for-status-to-be-reported

@sherine-k sherine-k closed this Dec 9, 2025
@sherine-k
Copy link
Author

closing temporarily and reopening to trigger GH actions

@sherine-k sherine-k reopened this Dec 9, 2025
@sherine-k sherine-k requested a review from kmk142789 December 9, 2025 13:39
@sherine-k
Copy link
Author

/azp run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FR: Support a WithMirror option

4 participants