This repository was archived by the owner on Jun 30, 2025. It is now read-only.
drop custom prefix option #898
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #898 +/- ##
==========================================
- Coverage 73.94% 73.64% -0.31%
==========================================
Files 17 17
Lines 3282 3282
==========================================
- Hits 2427 2417 -10
- Misses 855 865 +10
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
sergiud
force-pushed
the
custom-prefix
branch
from
b1782fe to
24d80b9
Compare
Contributor
|
Awesome, @sergiud! We can also remove "That feature must be enabled at compile time by the WITH_CUSTOM_PREFIX flag." from |
sergiud
force-pushed
the
custom-prefix
branch
from
24d80b9 to
692d194
Compare
Contributor
Author
|
@santigl Good point, thanks. Updated. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already enable custom prefix by default (#788). Promote custom prefix to first class citizen in order to eliminate unit test code duplication.
cc @santigl