Skip to content
This repository was archived by the owner on Jun 30, 2025. It is now read-only.

Conversation

@Arfrever
Copy link

@Arfrever Arfrever commented Jan 24, 2022

This implements suggestion from #57.

Before:

$ pkg-config --libs libglog
-lglog
$ pkg-config --libs --static libglog
-lglog

After:

$ pkg-config --libs libglog
-lglog
$ pkg-config --libs --static libglog
-lglog -lunwind -lpthread -lgflags

By the way, I was also trying get_target_property(some_output_variable glog LINK_LIBRARIES), but it provides raw cmake-style value such as unwind::unwind;-lpthread;gflags which would need complicated parsing and transformation, so the solution used in this pull request seems easier.

Copy link
Contributor

@sergiud sergiud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Only some nitpicks.

@sergiud sergiud added this to the 0.6 milestone Jan 25, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jan 25, 2022

Codecov Report

Merging #787 (1f5efdf) into master (1883610) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #787   +/-   ##
=======================================
  Coverage   72.72%   72.72%           
=======================================
  Files          17       17           
  Lines        3256     3256           
=======================================
  Hits         2368     2368           
  Misses        888      888           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1883610...1f5efdf. Read the comment docs.

@sergiud
Copy link
Contributor

sergiud commented Jan 25, 2022

Thanks!

@sergiud sergiud merged commit bc1fada into google:master Jan 25, 2022
@Arfrever Arfrever deleted the libglog.pc_private_libs branch January 27, 2022 01:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

libglog.pc.in should include libunwind as private dep for static linking case

3 participants