This repository was archived by the owner on Jun 30, 2025. It is now read-only.
libglog.pc: Set Libs.private for static linking #787
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements suggestion from #57.
Before:
After:
By the way, I was also trying
get_target_property(some_output_variable glog LINK_LIBRARIES), but it provides raw cmake-style value such asunwind::unwind;-lpthread;gflagswhich would need complicated parsing and transformation, so the solution used in this pull request seems easier.