This repository was archived by the owner on Jun 30, 2025. It is now read-only.
LogCleaner: make overdue_days_ unsigned int
#760
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #760 +/- ##
==========================================
- Coverage 73.02% 73.01% -0.01%
==========================================
Files 17 17
Lines 3218 3217 -1
==========================================
- Hits 2350 2349 -1
Misses 868 868
Continue to review full report at Codecov.
|
Since the value of `LogCleaner::overdue_days_` should be >= 0, we can simply make it an unsigned int which also avoids unnecessary assertions. Signed-off-by: Marco Wang <[email protected]>
Contributor
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the value of
LogCleaner::overdue_days_should be >= 0,we can simply make it an unsigned int which also avoids
unnecessary assertions.
Signed-off-by: Marco Wang <[email protected]>