-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Support stack unwind on Android #708
Conversation
|
Thanks for the contribution. However, many of the changes are more than questionable. Therefore, please provide a description of the purpose of this PR. |
|
Is there a chance you could setup a Github action that uses (any) Android NDK? Without a CI pipeline, it is very likely that the Android support will break again. |
|
OK, I will make a separate PR for Android CI. |
|
Thank you. A separate PR is not needed though. You can add the Github action as part of this PR. This will also ensure your changes actually work. |
|
CI added. I disabled tests since running tests requires emulators. |
|
Thanks, this looks great now! Some nitpicks:
|
.github/workflows/android-build.yml
Outdated
| -DANDROID_STL=c++_shared \ | ||
| -DANDROID_NATIVE_API_LEVEL=24 \ | ||
| -DANDROID_ABI=${{matrix.abi}} \ | ||
| -DBUILD_TESTING=OFF |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would still build the tests to ensure at least linking works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. I have to set ANDROID_NATIVE_API_LEVEL to at least 28. Because glob function used by tests is introduced in 28.
|
Thanks! |
No description provided.