Skip to content
This repository was archived by the owner on Jun 30, 2025. It is now read-only.

Conversation

@romange
Copy link
Contributor

@romange romange commented May 23, 2021

  1. Use CYGWIN variable to test for WIN32 because WIN32 var has been deprecated in later versions of cmake.
  2. Translate TEST_SRC_DIR to windows paths because posix open() calls can not handle unix-like paths in cygwin environment.

@google-cla google-cla bot added the cla: yes label May 23, 2021
1. Use CYGWIN variable to test for WIN32 because WIN32 var has been deprecated in later versions of cmake.
2. Translate TEST_SRC_DIR to windows paths because posix open calls can not handle unix-like paths in cygwin environment.
@romange
Copy link
Contributor Author

romange commented May 23, 2021

PTAL

@sergiud sergiud self-assigned this May 23, 2021
@sergiud sergiud added this to the 0.6 milestone May 23, 2021
@sergiud sergiud merged commit fef48c1 into google:master May 23, 2021
@romange romange deleted the cygwin branch May 23, 2021 14:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants