Skip to content
This repository was archived by the owner on Jun 30, 2025. It is now read-only.
This repository was archived by the owner on Jun 30, 2025. It is now read-only.

Bazel build doesn't set correct compile flags. #430

@plmuon

Description

@plmuon

We're using the bazel build (bazel/glog.bzl).
It contains 2 genrules that generate some of the header files.
In addition, it has a build rule (native.cc_library) that compiles the source (using the generated header files) with -D flags. These flags are fixed in the rule and not derived from the system (like with the cmake build or autogen/configure/make.

Amongst others, -DHAVE_UNISTD_H is not defined. This results in symlinks not being created.

For our local build, I have now overridden the bazel build file and added a few flags that are appropriate to our environment manually, which is only a workaround for our local context:
"-DHAVE_UNISTD_H",
"-DHAVE_PWD_H",
"-DHAVE_SYSLOG_H",
"-DHAVE_PWRITE",
"-DHAVE_FCNTL",

I assume google's internal version uses blaze (?) and might have solved this?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions