Revert a change that inexplicably caused a large perf regression. #2499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qining
approved these changes
Dec 20, 2018
Not entirely sure why this was causing a perf regression, it should be faster if anything, but reverting until we can investigate further.
AWoloszyn
force-pushed
the
prime-depth-by-rendering
branch
from
f95c914 to
a69f7ec
Compare
Contributor
Author
|
Updated to also fix the presubmit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not entirely sure why this was causing a perf regression,
it should be faster if anything, but reverting until we
can investigate further.