Fix JDWP interception to work if debug names are missing. #2479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We currently lookup an argument to one of the breakpointed methods by name. However, if the debug info is stripped, the names returned by the JVM debugger are all the empty string. This change makes it possible to look for arguments by index as well. This depends on the fact that the Android debugger always labels the "this" argument with a name[0] and that the arguments are stored in successive slots in the DEX[1]. [0] https://android.googlesource.com/platform/art/+/39d8c873645df7c956bf306693d95212d1d51906/libdexfile/dex/dex_file-inl.h#236 [1] Same as [0], but lines 254+
AWoloszyn
approved these changes
Dec 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently lookup an argument to one of the breakpointed methods by name. However, if the debug info is stripped, the names returned by the JVM debugger are all the empty string. This change makes it possible to look for arguments by index as well. This depends on the fact that the Android debugger always labels the "this" argument with a name[0] and that the arguments are stored in successive slots in the DEX[1].
[0] libdexfile/dex/dex_file-inl.h:236
[1] libdexfile/dex/dex_file-inl.h:254+