Support editing shaders in GLES MEC traces. #2415
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
I think the same approach should work for Vulkan. |
AWoloszyn
reviewed
Dec 5, 2018
AWoloszyn
approved these changes
Dec 5, 2018
Contributor
AWoloszyn
left a comment
AWoloszyn
left a comment
There was a problem hiding this comment.
Nit about factoring out initial state
Adds support for editing shaders that were created before the MEC capture started and thus have no `glShaderSource` call in the trace.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for editing shaders that were created before the MEC capture started and thus have no
glShaderSourcecall in the trace.As a dependency, this also adds support for tracking the context that created a resource and allows the texture view to filter by context (see #1025).
Fixes #2066