Fix Compressed Texture Compat #2318
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In `compat.go` compressed texture commands check whether the replay target supports the requested compressed format. However, commands that can be used for both uncompressed and compressed textures, such as `glTexStorage2d`, did not in the case of ODR.
The GLES 3.0 and OpenGL 4.3 specs require some compressed formats to be implemented, so we can assume they are present on the specific versions.
ben-clayton
approved these changes
Oct 28, 2018
AWoloszyn
approved these changes
Oct 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
compat.gocompressed texture commands check whether the replay target supports the requested compressed format. However, commands that can be used for both uncompressed and compressed textures, such asglTexStorage2d, did not in the case of ODR.The GLES 3.0 and OpenGL 4.3 specs require some compressed formats to be implemented, so we can assume they are present on the specific versions.