Allow gapit screenshot to create multiple screenshots in one go
#2259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ben-clayton
approved these changes
Oct 2, 2018
core/app/flags/flags.go
Outdated
| } | ||
| s.Bind(fullname, field.Addr().Interface(), usage) | ||
|
|
||
| if tags.Get("repeated") == "true" { |
Contributor
There was a problem hiding this comment.
Do we need the repeated tag? Isn't having the type a slice enough info?
Member
Author
There was a problem hiding this comment.
Done. Changed it so that slices are automatically repeated flags.
Flag values that are slices are treated as repeatable flags, where successive instances will append the new value to the slice.
Makes the `--at` and `--frame` arguments repeatable.
When combined with `--frame`, `--draw` will cause `gapit screenshot` to create a screenshot of every draw call in the frame.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the
--atand--frameflags repeatable and adds a--drawsflag to request a screenshot of every draw call.