Update how we handle descriptor sets again. #2204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qining
reviewed
Sep 13, 2018
| newOffsets := descriptors.bufferOffsets | ||
| for _, j, jj in offsets { | ||
| for _, k, v in jj { | ||
| newOffsets[j][k][v] = true |
Contributor
There was a problem hiding this comment.
As discussed offline, multi-layer maps need special care
This provides some performance benefit.
AWoloszyn
force-pushed
the
update_descriptors
branch
from
184c698 to
8dd8a8b
Compare
qining
approved these changes
Sep 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides some performance benefit.