Copy depth aspect by rendering in overdraw #2079
Conversation
sean-purcell
force-pushed
the
overdraw-render
branch
from
232d4a0 to
39f43b8
Compare
gapis/api/vulkan/image_primer.go
Outdated
| } | ||
| } | ||
|
|
||
| func imageBarrierAspectFlags(aspect VkImageAspectFlagBits, fmt VkFormat) VkImageAspectFlags { |
There was a problem hiding this comment.
Personally I'd prefer name it ipImageBarrierAspectFlags. imageBarrierAspectFlags sounds quite general to me, and should be reserved for api utility subroutines or extern functions.
gapis/api/vulkan/image_primer.go
Outdated
| memory.Nullptr, | ||
| 0, | ||
| memory.Nullptr, | ||
| 1, |
gapis/api/vulkan/image_primer.go
Outdated
| input.image.Info().ArrayLayers(), // layerCount | ||
| ), | ||
| )) | ||
| dstBarriers = append(dstBarriers, |
There was a problem hiding this comment.
-
Prefer to have a check to see if the
finalLayoutand the current layout is the same. Because for primeByRendering jobs, the layout of input attachments are guaranteed to be SHADER_READ_ONLY_OPTIMAL before the rendering (line 80), so this is not necessary for those cases, also the barriers for the input attachments in theinputSrcBarriersabove. -
When
render()is called from places other thanprimeByRenderingfor aspects other than ONLY stencil, not used when priming for COLOR or DEPTH aspects, so that layout transitions for input attachments can be missed.
There was a problem hiding this comment.
Sorry, the 2) point is not valid, and for the 1) not necessary for the inputSrcBarriers, I misunderstood the code here.
Specifically do this for the store end (i.e. new depth/stencil image to old image), so that we don't have to add TRANSFER_DST to all depth images.
sean-purcell
force-pushed
the
overdraw-render
branch
from
39f43b8 to
3eb3aec
Compare
|
|
|
Also adding a fix for an incorrect handling of clear values that led to the stencil aspect being cleared to the wrong value sometimes. |
3 participants
Specifically do this for the store end (i.e. new depth/stencil image to
old image), so that we don't have to add TRANSFER_DST to all depth
images.
Additionally, remove the conditions in gapii and always add the transfer_src flag to images, so that we can use it to copy from at the start of the overdraw renderpass.