Revert the threadId when a command is reverted. #1853
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The replay builder can revert commands (e.g. due to GL errors). However, the revert was not reverting the command builder's state correctly when the thread changed with the reverted command. Thus, if in BeginCommand it was determined that the thread has changed, a `SWITCH_THREAD` opcode is prepared, but then reverted, while the command builder would go on, assuming it has switched threads.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The replay builder can revert commands (e.g. due to GL errors). However, the revert was not reverting the command builder's state correctly when the thread changed with the reverted command. Thus, if in BeginCommand it was determined that the thread has changed, a
SWITCH_THREADopcode is prepared, but then reverted, while the command builder would go on, assuming it has switched threads.