Skip to content

inject no long for FBS generation to remove logs in flattests#7926

Merged
dbaileychess merged 2 commits intogoogle:masterfrom
dbaileychess:master
Apr 28, 2023
Merged

inject no long for FBS generation to remove logs in flattests#7926
dbaileychess merged 2 commits intogoogle:masterfrom
dbaileychess:master

Conversation

@dbaileychess
Copy link
Copy Markdown
Collaborator

Whenever flattest was ran, it was printing errors out to stderr as part of the test. Added the ability to inject a no log to the FBS generator to suppress this.

@github-actions github-actions bot added c++ codegen Involving generating code from schema labels Apr 28, 2023
@dbaileychess dbaileychess force-pushed the master branch 4 times, most recently from 35f8340 to 2146396 Compare April 28, 2023 20:08
@dbaileychess dbaileychess enabled auto-merge (squash) April 28, 2023 20:38
@dbaileychess dbaileychess disabled auto-merge April 28, 2023 20:40
@dbaileychess dbaileychess merged commit 966aae2 into google:master Apr 28, 2023
jochenparm pushed a commit to jochenparm/flatbuffers that referenced this pull request Oct 29, 2024
…#7926)

* inject no long for FBS generation to remove logs in flattests

* updated blaze rules
jochenparm pushed a commit to jochenparm/flatbuffers that referenced this pull request Oct 29, 2024
…#7926)

* inject no long for FBS generation to remove logs in flattests

* updated blaze rules
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ codegen Involving generating code from schema

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant