Allow to use functions from BuildFlatBuffers.cmake from a flatbuffe…#7912
Merged
dbaileychess merged 2 commits intogoogle:masterfrom Apr 26, 2023
Merged
Conversation
…rs installation installed with CMake.
dbaileychess
approved these changes
Apr 26, 2023
Collaborator
|
Feel free to do another PR with the alias, as that sounds better. |
jochenparm
pushed a commit
to jochenparm/flatbuffers
that referenced
this pull request
Oct 29, 2024
…rs installation installed with CMake. (google#7912) Co-authored-by: Derek Bailey <derekbailey@google.com>
jochenparm
pushed a commit
to jochenparm/flatbuffers
that referenced
this pull request
Oct 29, 2024
…rs installation installed with CMake. (google#7912) Co-authored-by: Derek Bailey <derekbailey@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…rs installation installed with CMake.
Solves #7909
I tried to build and install flatbuffers (including flatc) with CMake.
When trying to integrate that install into my project, I realized that the very convenient
flatbuffers_generate_headersfunctions could not be used.This PR fixes that.
(Instead of adding this clause
it would also be possible to create an
ALIAStargetflatbuffers::flatc(e.g.add_executable(flatbuffers::flatc ALIAS flatc)and reference that throughout the the whole project. Doing the same for the other targets (e.g.flatbuffers::flatbuffers... ) allows the same experience for both consumers who build flatbuffers as part of their build, or use an installed version instead. But this PR goes the easier, quick way to fix the described problem.)