Skip to content

Go: add test for FinishWithFileIdentifier#7905

Merged
le-michael merged 2 commits intogoogle:masterfrom
jdemeyer:go-finish-with-file-identifier-test
Apr 12, 2023
Merged

Go: add test for FinishWithFileIdentifier#7905
le-michael merged 2 commits intogoogle:masterfrom
jdemeyer:go-finish-with-file-identifier-test

Conversation

@jdemeyer
Copy link
Copy Markdown
Contributor

Basic tests for Builder.FinishSizePrefixed, Builder.FinishWithFileIdentifier and builder.FinishSizePrefixedWithFileIdentifier. The last two functions were not tested yet in go_test.go.

Copy link
Copy Markdown
Contributor

@le-michael le-michael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@le-michael le-michael merged commit 3fda20d into google:master Apr 12, 2023
jochenparm pushed a commit to jochenparm/flatbuffers that referenced this pull request Oct 29, 2024
Co-authored-by: Michael Le <michael.le647@gmail.com>
jochenparm pushed a commit to jochenparm/flatbuffers that referenced this pull request Oct 29, 2024
Co-authored-by: Michael Le <michael.le647@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants