Only use absl headers if C++14 is available.#7824
Merged
dbaileychess merged 1 commit intogoogle:masterfrom Feb 15, 2023
Merged
Conversation
Collaborator
|
I would rather add a |
If flatbuffers is built in C++11 mode, but there is a recent version of absl which requires C++14, the build will fail. Cf MapServer/MapServer#6822 for the use case that triggered this.
rouault
force-pushed
the
FLATBUFFERS_DO_NOT_USE_ABSL
branch
from
cde8c4b to
3d88680
Compare
Contributor
Author
indeed :-) Just amended this PR with this |
rouault
changed the title
dbaileychess
approved these changes
Feb 15, 2023
rouault
added a commit
to rouault/mapserver
that referenced
this pull request
Feb 15, 2023
Port of upstream fix in google/flatbuffers#7824
bob-beck
pushed a commit
to openbsd/ports
that referenced
this pull request
Feb 16, 2023
github-actions bot
pushed a commit
to MapServer/MapServer
that referenced
this pull request
Feb 16, 2023
Port of upstream fix in google/flatbuffers#7824
jmckenna
pushed a commit
to MapServer/MapServer
that referenced
this pull request
Feb 16, 2023
Port of upstream fix in google/flatbuffers#7824 Co-authored-by: Even Rouault <even.rouault@spatialys.com>
This was referenced Feb 24, 2023
dbaileychess
pushed a commit
that referenced
this pull request
Mar 15, 2023
If flatbuffers is built in C++11 mode, but there is a recent version of absl which requires C++14, the build will fail. Cf MapServer/MapServer#6822 for the use case that triggered this.
ryanakca
pushed a commit
to ryanakca/OpenBSD-ports
that referenced
this pull request
Mar 22, 2023
4 tasks
jochenparm
pushed a commit
to jochenparm/flatbuffers
that referenced
this pull request
Oct 29, 2024
If flatbuffers is built in C++11 mode, but there is a recent version of absl which requires C++14, the build will fail. Cf MapServer/MapServer#6822 for the use case that triggered this.
jochenparm
pushed a commit
to jochenparm/flatbuffers
that referenced
this pull request
Oct 29, 2024
If flatbuffers is built in C++11 mode, but there is a recent version of absl which requires C++14, the build will fail. Cf MapServer/MapServer#6822 for the use case that triggered this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If flatbuffers is built in C++11 mode, but there is a recent version of absl which requires C++14, the build will fail.
Cf MapServer/MapServer#6822 for the use case that triggered this.