TS/JS: Export object based classes on entry#7822
Merged
dbaileychess merged 4 commits intogoogle:masterfrom Mar 3, 2023
Merged
Conversation
Along with the non object ones, for consistency. This is a regression
introduced recently.
Before:
`export { UpdateSettingsRequest } from './worker/update-settings-request.js';`
Now:
`export { UpdateSettingsRequest, UpdateSettingsRequestT } from './worker/update-settings-request.js';`
github-actions
bot
added
c++
codegen
jmillan
added a commit
to versatica/mediasoup
that referenced
this pull request
Feb 9, 2023
This reverts commit 6c10e82. Until the following regression fix is implemented: google/flatbuffers#7822
Contributor
Author
|
I'll fix Generated Code checks. |
Enums are not elegible.
Contributor
Author
|
CodeQL action failing. I've run locally and I don't get any error. I can't re-rerun the action, probably due to permissions in the repo, in case this was due to some temporal error. @dbaileychess, what do you think about this PR? Object based classes were before exported along with non object ones. I consider their absence a regression, and good to have both exported at the same level. |
Collaborator
|
Sorry for forgetting about the object API when reworking the export logic. The fix looks good to me, thanks. |
Contributor
Author
|
Hi, Any chance this PR can be reviewed? |
Contributor
Author
|
Please, can this PR have few minutes for review? It fixes a regression which makes otherwise add a great amount of import statements in user code. @bjornharrtell confirms the issue and considers the PR OK. I'd like to avoid changing my code so much due to the issue that is fixed here. |
Collaborator
|
Ping @dbaileychess |
dbaileychess
approved these changes
Mar 3, 2023
dbaileychess
added a commit
that referenced
this pull request
Mar 15, 2023
* TS/JS: Export object based classes on entry
Along with the non object ones, for consistency. This is a regression
introduced recently.
Before:
`export { UpdateSettingsRequest } from './worker/update-settings-request.js';`
Now:
`export { UpdateSettingsRequest, UpdateSettingsRequestT } from './worker/update-settings-request.js';`
* only export object based classes for structs
Enums are not elegible.
---------
Co-authored-by: Björn Harrtell <bjornharrtell@users.noreply.github.com>
Co-authored-by: Derek Bailey <derekbailey@google.com>
jochenparm
pushed a commit
to jochenparm/flatbuffers
that referenced
this pull request
Oct 29, 2024
* TS/JS: Export object based classes on entry
Along with the non object ones, for consistency. This is a regression
introduced recently.
Before:
`export { UpdateSettingsRequest } from './worker/update-settings-request.js';`
Now:
`export { UpdateSettingsRequest, UpdateSettingsRequestT } from './worker/update-settings-request.js';`
* only export object based classes for structs
Enums are not elegible.
---------
Co-authored-by: Björn Harrtell <bjornharrtell@users.noreply.github.com>
Co-authored-by: Derek Bailey <derekbailey@google.com>
jochenparm
pushed a commit
to jochenparm/flatbuffers
that referenced
this pull request
Oct 29, 2024
* TS/JS: Export object based classes on entry
Along with the non object ones, for consistency. This is a regression
introduced recently.
Before:
`export { UpdateSettingsRequest } from './worker/update-settings-request.js';`
Now:
`export { UpdateSettingsRequest, UpdateSettingsRequestT } from './worker/update-settings-request.js';`
* only export object based classes for structs
Enums are not elegible.
---------
Co-authored-by: Björn Harrtell <bjornharrtell@users.noreply.github.com>
Co-authored-by: Derek Bailey <derekbailey@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Along with the non object ones, for consistency. This is a regression introduced recently.
Before:
export { UpdateSettingsRequest } from './worker/update-settings-request.js';Now:
export { UpdateSettingsRequest, UpdateSettingsRequestT } from './worker/update-settings-request.js';