Skip to content

Add CI step to build with -DFLATBUFFERS_NO_FILE_TESTS. #7729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dbaileychess merged 6 commits into from
Dec 22, 2022
Merged

Add CI step to build with -DFLATBUFFERS_NO_FILE_TESTS. #7729

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a08f5cf
Add CI step to build with -DFLATBUFFERS_NO_FILE_TESTS
engedy Dec 21, 2022
b391a36
Fix cmake syntax
engedy Dec 21, 2022
b0166ac
Further fix cmake argumetns
engedy Dec 21, 2022
42ab900
Add workaround for unused-parameter.
engedy Dec 21, 2022
6534539
Merge branch 'master' into engedy-patch-1
dbaileychess Dec 21, 2022
5c80ed0
Remove build matrix
engedy Dec 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,16 @@ jobs:
if: matrix.cxx == 'g++-10' && startsWith(github.ref, 'refs/tags/')
id: hash-gcc
run: echo "::set-output name=hashes::$(sha256sum Linux.flatc.binary.${{ matrix.cxx }}.zip | base64 -w0)"

build-linux-no-file-tests:
name: Build Linux with -DFLATBUFFERS_NO_FILE_TESTS
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- name: cmake
run: CXX=clang++-12 cmake -G "Unix Makefiles" -DCMAKE_BUILD_TYPE=Release -DFLATBUFFERS_STRICT_MODE=ON -DFLATBUFFERS_CXX_FLAGS="-DFLATBUFFERS_NO_FILE_TESTS" .
- name: build
run: make -j

build-linux-cpp-std:
name: Build Linux C++
Expand Down
3 changes: 3 additions & 0 deletions tests/test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1511,6 +1511,9 @@ int FlatBufferTests(const std::string &tests_data_path) {
ParseIncorrectMonsterJsonTest(tests_data_path);
FixedLengthArraySpanTest(tests_data_path);
DoNotRequireEofTest(tests_data_path);
#else
// Guard against -Wunused-parameter.
(void)tests_data_path;
#endif

UtilConvertCase();
Expand Down