chore: emit more reasonable error message when using incomplete type …#7678
Merged
dbaileychess merged 2 commits intogoogle:masterfrom Nov 29, 2022
Merged
chore: emit more reasonable error message when using incomplete type …#7678dbaileychess merged 2 commits intogoogle:masterfrom
dbaileychess merged 2 commits intogoogle:masterfrom
Conversation
dbaileychess
approved these changes
Nov 29, 2022
sunwen18
pushed a commit
to sunwen18/flatbuffers
that referenced
this pull request
Dec 25, 2022
…in struct (google#7678) Co-authored-by: Derek Bailey <derekbailey@google.com>
candhyan
pushed a commit
to mediaz/flatbuffers
that referenced
this pull request
Jan 2, 2023
…in struct (google#7678) Co-authored-by: Derek Bailey <derekbailey@google.com>
jochenparm
pushed a commit
to jochenparm/flatbuffers
that referenced
this pull request
Oct 29, 2024
…in struct (google#7678) Co-authored-by: Derek Bailey <derekbailey@google.com>
jochenparm
pushed a commit
to jochenparm/flatbuffers
that referenced
this pull request
Oct 29, 2024
…in struct (google#7678) Co-authored-by: Derek Bailey <derekbailey@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Emit more reasonable error message when using incomplete type in struct.
Example:
When parsing this schema, flatc will emit a confusing error message: "structs may contain only scalar or struct fields".
In fact, it's not allowed because struct A is an incomplete type when parsing struct B, we can't get A's size and other information at this point.