Skip to content

Remove redundant calls to String.toString() #636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 6, 2017
Merged

Remove redundant calls to String.toString() #636

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
.idea/dataSources.ids
.idea/codeStyleSettings.xml
.idea/compiler.xml
.idea/encodings.xml
.idea/modules.xml
.idea/uiDesigner.xml
.idea/libraries
Expand Down
2 changes: 1 addition & 1 deletion core/src/main/java/com/google/errorprone/bugpatterns/HashtableContains.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ public Description matchMethodInvocation(MethodInvocationTree tree, VisitorState
}

private Fix replaceMethodName(MethodInvocationTree tree, VisitorState state, String newName) {
String source = state.getSourceForNode((JCTree) tree.getMethodSelect()).toString();
String source = state.getSourceForNode((JCTree) tree.getMethodSelect());
int idx = source.lastIndexOf("contains");
String replacement =
source.substring(0, idx) + newName + source.substring(idx + "contains".length());
Expand Down
2 changes: 1 addition & 1 deletion docgen/src/main/java/com/google/errorprone/BugPatternFileGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ public boolean processLine(String line) throws IOException {
.put("title", pattern.name)
.put("summary", pattern.summary)
.put("layout", "bugpattern")
.put("category", pattern.category.toString())
.put("category", pattern.category)
.put("severity", pattern.severity.toString())
.build();
DumperOptions options = new DumperOptions();
Expand Down