python: Assert that libdir is a Path in all branches #1992
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `inplace=True` branch previously relied on some non-trivial interactions between `str` and `pathlib.Path` objects, which produces unexpected values in cases of `s / p`, where `s` is a string and `p` is an absolute path. To fix, just create a `pathlib.Path` of the return value of `build_py.get_package_dir()`.
dmah42
approved these changes
Aug 12, 2025
BuildMonkey
pushed a commit
to BuildMonkey/benchmark
that referenced
this pull request
Aug 13, 2025
The `inplace=True` branch previously relied on some non-trivial interactions between `str` and `pathlib.Path` objects, which produces unexpected values in cases of `s / p`, where `s` is a string and `p` is an absolute path. To fix, just create a `pathlib.Path` of the return value of `build_py.get_package_dir()`. Co-authored-by: dominic <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
inplace=Truebranch previously relied on some non-trivial interactions betweenstrandpathlib.Pathobjects, which produces unexpected values in cases ofs / p, wheresis a string andpis an absolute path.To fix, just create a
pathlib.Pathof the return value ofbuild_py.get_package_dir().