Skip to content

fix: session_service.create_session issue #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 28 commits into
base: main
Choose a base branch
from
Open

fix: session_service.create_session issue #401

wants to merge 28 commits into from

Conversation

hsuyuming
Copy link
Contributor

session_service.create_session is a coroutine,so we need to use asyncio.run + await to get the value

@hsuyuming
Copy link
Contributor Author

@koverholt Do you mind to help me review my PR when you get time? Thank you very much.

pwwpche
pwwpche reviewed Jul 16, 2025
View reviewed changes
pwwpche
pwwpche reviewed Jul 16, 2025
View reviewed changes
pwwpche
pwwpche reviewed Jul 16, 2025
View reviewed changes
pwwpche
pwwpche reviewed Jul 16, 2025
View reviewed changes
Copy link
Contributor

@pwwpche pwwpche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for helping updating the examples! I've left a few comments regarding the auth example.

@lavinigam-gcp lavinigam-gcp self-requested a review July 16, 2025 18:57
@lavinigam-gcp lavinigam-gcp self-assigned this Jul 16, 2025
@hsuyuming
Copy link
Contributor Author

Hi @pwwpche:
Thank you for your suggestion. I already do some modification base on those. Please help me review again, if there are any item need to be enhance, free feel to let me know. Thank you!

@hsuyuming hsuyuming requested a review from pwwpche July 17, 2025 20:43
@hsuyuming
Copy link
Contributor Author

Hi @pwwpche & @lavinigam-gcp :
Can you help me review my PR again when you get time? Thank you

@hsuyuming
Copy link
Contributor Author

Hi @pwwpche @lavinigam-gcp Can you help me review onece?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lavinigam-gcp lavinigam-gcp Awaiting requested review from lavinigam-gcp

@pwwpche pwwpche Awaiting requested review from pwwpche

At least 1 approving review is required to merge this pull request.

Assignees

@lavinigam-gcp lavinigam-gcp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hsuyuming @pwwpche @lavinigam-gcp