Skip to content

Update glog to include the patch to fix syscall deprecation warnings on a mac #167

@bgogul

Description

@bgogul

When building the project on a mac, we get the following error, which is caused by glog:

ERROR: /private/var/tmp/_bazel_bgogul/f1fbc693a6ebe337e3642fd2ccad3763/external/glog/BUILD.bazel:5:13: Compiling src/utilities.cc failed: (Exit 1): cc_wrapper.sh failed: error executing command external/local_config_cc/cc_wrapper.sh -U_F\
ORTIFY_SOURCE -fstack-protector -Wall -Wthread-safety -Wself-assign -fcolor-diagnostics -fno-omit-frame-pointer '-std=c++0x' -MD -MF ... (remaining 46 argument(s) skipped)

Use --sandbox_debug to see verbose messages from the sandbox
external/glog/src/utilities.cc:251:17: error: 'syscall' is deprecated: first deprecated in macOS 10.12 - syscall(2) is unsupported; please switch to a supported interface. For SYS_kdebug_trace use kdebug_signpost(). [-Werror,-Wdeprecated\
-declarations]
    pid_t tid = syscall(__NR_gettid);
                ^
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/unistd.h:742:6: note: 'syscall' has been explicitly marked deprecated here
int      syscall(int, ...);
         ^
1 error generated.

google/glog#685 has a patch that fixes this issue. We should incorporate that patch to our WORKSPACE file or upgrade glog when the patch is available in a release.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions