Skip to content

Fix #5876: Windows build fails with OpenCV 3.4.10 #5877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix #5876: Windows build fails with OpenCV 3.4.10 #5877

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/getting_started/install.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -613,7 +613,7 @@ next section.
8. Install OpenCV.

Download the Windows executable from https://opencv.org/releases/ and
install. We currently use OpenCV 3.4.10. Remember to edit the [`WORKSPACE`]
install. We currently use OpenCV 3.4.12. Remember to edit the [`WORKSPACE`]
file if OpenCV is not installed at `C:\opencv`.

```
Expand Down
4 changes: 2 additions & 2 deletions third_party/opencv_windows.BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ licenses(["notice"]) # BSD license

exports_files(["LICENSE"])

OPENCV_VERSION = "3410" # 3.4.10
OPENCV_VERSION = "3412" # 3.4.12

config_setting(
name = "opt_build",
Expand All @@ -17,7 +17,7 @@ config_setting(
values = {"compilation_mode": "dbg"},
)

# The following build rule assumes that the executable "opencv-3.4.10-vc14_vc15.exe"
# The following build rule assumes that the executable "opencv-3.4.12-vc14_vc15.exe"
# is downloaded and the files are extracted to local.
# If you install OpenCV separately, please modify the build rule accordingly.
cc_library(
Expand Down