Add go-aip guidelines for resource-oriented gRPC APIs#8
Merged
gonzaloserrano merged 5 commits intomainfrom Mar 1, 2026
Merged
Conversation
Add comprehensive reference document covering Google AIP standards with einride/aip-go: resource names, standard methods, pagination, filtering, ordering, field masks, and field behavior annotations. https://claude.ai/code/session_01KUbKvTowcMQbj7Wn3oWr7B
There was a problem hiding this comment.
3 issues found across 4 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="skills/gopilot/reference/go-aip.md">
<violation number="1" location="skills/gopilot/reference/go-aip.md:229">
P1: `filtering.ProtoDeclarations` does not appear to exist in the einride/aip-go library. The filtering package provides `filtering.NewDeclarations(...)` with explicit `DeclareIdent` calls to define the schema. Consider removing this section or replacing with the documented approach.</violation>
<violation number="2" location="skills/gopilot/reference/go-aip.md:259">
P1: `field.Path` is a `string`, not `[]string`, so `strings.Join(field.Path, ".")` won't compile. According to the [einride/aip-go ordering docs](https://pkg.go.dev/go.einride.tech/aip/ordering), `Field.Path` is already a dot-separated string. Use `field.Path` directly.</violation>
</file>
<file name="skills/gopilot/SKILL.md">
<violation number="1" location="skills/gopilot/SKILL.md:351">
P2: Field masks AIP number is incomplete — should reference AIP-161 (the canonical field mask AIP), not just AIP-134 (which is the Update method). The project's own `reference/go-aip.md` correctly cites both: `(AIP-134, AIP-161)`.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
- Remove non-existent filtering.ProtoDeclarations, use NewDeclarations with explicit DeclareIdent calls instead - Fix ordering field.Path: it's a string, not []string, no Join needed - Add AIP-161 to field masks reference in SKILL.md https://claude.ai/code/session_01KUbKvTowcMQbj7Wn3oWr7B
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add comprehensive reference document covering Google AIP standards
with einride/aip-go: resource names, standard methods, pagination,
filtering, ordering, field masks, and field behavior annotations.
https://claude.ai/code/session_01KUbKvTowcMQbj7Wn3oWr7B