Skip to content

feat: add safety tables, sync decision guide, goleak, and noCopy pattern#12

Merged
gonzaloserrano merged 2 commits intomainfrom
feat/add-safety-and-concurrency-patterns
Mar 26, 2026
Merged

feat: add safety tables, sync decision guide, goleak, and noCopy pattern#12
gonzaloserrano merged 2 commits intomainfrom
feat/add-safety-and-concurrency-patterns

Conversation

@gonzaloserrano
Copy link
Copy Markdown
Owner

  • Low-cardinality error messages (don't interpolate IDs into error strings)
  • Nil safety table (nil map/slice/channel behavior)
  • Slice aliasing trap with full-slice expression fix
  • Copy semantics quick reference table
  • context.WithoutCancel for background work
  • Sync primitive decision table (atomic vs mutex vs channel vs errgroup)
  • noCopy sentinel pattern with go vet enforcement
  • goleak goroutine leak detection in tests
  • Extract security checklist to reference/security-checklist.md
  • Compress AIP and security helpers sections

Bump version to 1.0.25

- Low-cardinality error messages (don't interpolate IDs into error strings)
- Nil safety table (nil map/slice/channel behavior)
- Slice aliasing trap with full-slice expression fix
- Copy semantics quick reference table
- context.WithoutCancel for background work
- Sync primitive decision table (atomic vs mutex vs channel vs errgroup)
- noCopy sentinel pattern with go vet enforcement
- goleak goroutine leak detection in tests
- Extract security checklist to reference/security-checklist.md
- Compress AIP and security helpers sections

Bump version to 1.0.25
Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 6 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="skills/gopilot/SKILL.md">

<violation number="1" location="skills/gopilot/SKILL.md:36">
P2: The example contradicts the low-cardinality rule: it still interpolates `name` into the error string. Use a stable message without variable data.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

Inline example contradicted the low-cardinality rule it introduced.
@gonzaloserrano gonzaloserrano merged commit 9acda65 into main Mar 26, 2026
2 checks passed
@gonzaloserrano gonzaloserrano deleted the feat/add-safety-and-concurrency-patterns branch March 26, 2026 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant