Skip to content

Conversation

ryancurrah
Copy link
Member

added a new linter gomodguard, disabled by default

@CLAassistant
Copy link

CLAassistant commented Apr 4, 2020

CLA assistant check
All committers have signed the CLA.

@ryancurrah
Copy link
Member Author

Looks like the build failed for no reason. If someone could re-launch it that would be great. Otherwise I'll just push a superfluous commit.

Copy link
Member

@ernado ernado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

Please rebase from master, we've disabled vendoring.
Hope that it will fix failed build.

@ryancurrah ryancurrah requested a review from ernado April 22, 2020 00:25
@ryancurrah
Copy link
Member Author

Done

Copy link
Member

@ernado ernado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ernado ernado merged commit cbc2134 into golangci:master Apr 22, 2020
@ldez ldez added the linter: new Support new linter label Dec 7, 2020
@ldez ldez added this to the v1.25 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
linter: new Support new linter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants