Skip to content

extension: add debug menu for var show in doc #3818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

extension: add debug menu for var show in doc #3818

wants to merge 3 commits into from
+129 −1,022

Conversation

MistaTwista
Copy link

@MistaTwista MistaTwista commented Jul 26, 2025 •
edited
Loading

Fixes #3817

@MistaTwista
extension: add debug menu for var show in doc
b04ab94 
Adds a context-menu entry in the Variables views that opens the
selected string value in a new editor tab, rendering real newlines
instead of escape sequences.

Fixes golang#3817
@gopherbot
Copy link
Collaborator

This PR (HEAD: b04ab94) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/vscode-go/+/690675.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot
Copy link
Collaborator

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/690675.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

Please don’t reply on this GitHub thread. Visit golang.org/cl/690675.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from Ethan Reesor:

Patch Set 2: Commit-Queue+1

(5 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/690675.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from Go LUCI:

Patch Set 2:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-07-26T21:07:15Z","revision":"dd5438d74b8b10f1f8e2e6f22a9f76cc062c9e9c"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/690675.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from Ethan Reesor:

Patch Set 2: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/690675.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from Go LUCI:

Patch Set 2:

This CL has failed the run. Reason:

Tryjob golang/try/x_vscode-go-go1.24-linux-amd64_docker has failed with summary (view all results):

To reproduce, try gomote repro 8708248548731375393.

Additional links for debugging:

Please don’t reply on this GitHub thread. Visit golang.org/cl/690675.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from Go LUCI:

Patch Set 2: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/690675.
After addressing review feedback, remember to publish your drafts!

@MistaTwista
better parsing and use TextDocumentContentProvider
e35a9e8 
Also extended Delve context (clipboard) request used for longer strings
@gopherbot
Copy link
Collaborator

This PR (HEAD: e35a9e8) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/vscode-go/+/690675.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot
Copy link
Collaborator

Message from Maxim Kern:

Patch Set 2:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/690675.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from Maxim Kern:

Patch Set 3:

(4 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/690675.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from Ethan Reesor:

Patch Set 3: Code-Review+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/690675.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from Ethan Reesor:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/690675.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from Ethan Reesor:

Patch Set 3: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/690675.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from Go LUCI:

Patch Set 3:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-07-29T17:50:40Z","revision":"52c0b46d43ae0f232727f7cf89a3e432c584dc63"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/690675.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from Ethan Reesor:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/690675.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from Ethan Reesor:

Patch Set 3: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/690675.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from Go LUCI:

Patch Set 3:

This CL has failed the run. Reason:

Tryjob golang/try/x_vscode-go-go1.25-linux-amd64_docker has failed with summary (view all results):

To reproduce, try gomote repro 8707989126534927841.

Additional links for debugging:

Please don’t reply on this GitHub thread. Visit golang.org/cl/690675.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from Go LUCI:

Patch Set 3: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/690675.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from Hongxiang Jiang:

Patch Set 4: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/690675.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from Go LUCI:

Patch Set 4:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-07-29T18:35:57Z","revision":"c5b640bf456d1c303d4fcc5fbcd3066425f80cd2"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/690675.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from Hongxiang Jiang:

Patch Set 4: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/690675.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from Go LUCI:

Patch Set 4:

This CL has failed the run. Reason:

Tryjob golang/try/x_vscode-go-gotip-linux-amd64_docker has failed with summary (view all results):

To reproduce, try gomote repro 8707986277761597969.

Additional links for debugging:

Please don’t reply on this GitHub thread. Visit golang.org/cl/690675.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from Go LUCI:

Patch Set 4: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/690675.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

This PR (HEAD: 38e47f0) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/vscode-go/+/690675.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@MistaTwista MistaTwista marked this pull request as ready for review July 29, 2025 21:54
@gopherbot
Copy link
Collaborator

Message from Maxim Kern:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/690675.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from Hongxiang Jiang:

Patch Set 7:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/690675.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from Hongxiang Jiang:

Patch Set 7:

(8 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/690675.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Debugger] Feature request: “View string as document” for multiline strings
2 participants
@MistaTwista @gopherbot