benchfmt: return an error in case of a non UTF-8 encoded file#9
benchfmt: return an error in case of a non UTF-8 encoded file#9phenpessoa wants to merge 1 commit intogolang:masterfrom
Conversation
Currently, when using the benchstat tool to read files that are not UTF-8 encoded, it will fail silently. With this patch, when parsing non UTF-8 encoded files, benchfmt will now return an error instead letting the user know their input file is not properly formatted. Fixes golang/go#58579
|
This PR (HEAD: 680867c) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/perf/+/476055 to see it. Tip: You can toggle comments from me using the |
|
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be Please don’t reply on this GitHub thread. Visit golang.org/cl/476055. |
Currently, when using the benchstat tool to read files that are not UTF-8 encoded, it will fail silently. With this patch, when parsing non UTF-8 encoded files, benchfmt will now return an error instead letting the user know their input file is not properly formatted.
Fixes golang/go#58579