Skip to content

x/tools/gopls: SignatureHelp activeParameter always 0 after v0.18.1 #74329

Open
@skewb1k

Description

@skewb1k

After commit 2880aae, SignatureInformation.activeParameter does not have omitempty tag and always marshal. The problem is that its never assigned to anything and always 0, which overrides actual value in SignatureHelp.activeParameter, as stated in spec.

Solution is have same value as in SignatureHelp.activeParameter in SignatureInformation.activeParameter. The fix is minimal—just a one-line change —and I've submitted a PR.

Metadata

Metadata

Assignees

No one assigned

    Labels

    BugReportIssues describing a possible bug in the Go implementation.ToolsThis label describes issues relating to any tools in the x/tools repository.goplsIssues related to the Go language server, gopls.

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions