x/tools/gopls: show hex/binary literal with which a const was declared on mouse over

[soypat]

What did you do?

Mouse over a hex/binary notation integer

const hex, bin, oct = 0xe34e, 0b10101, 071

// Mouse over variable name `hex` or `bin` shows decimal representation
c := hex * bin

What did you expect to see?

The literal used to declare the const. Usually when one declares a const in hex, binary or octal representation it carries with it a significance, to aid the reader of the code. If we wrote programs for machines gofmt would convert these literals to decimals or whatever the computer like.

With the philosophy out of the way, I expected to see:

• const hex untyped int = 0xe34e (58190)
• const bin untyped int = 0b10101 (21).

What did you see instead?

The usual gopls help string of

• const hex untyped int = 58190
• const bin untyped int = 21.

[hyangah]

Isn't it a duplicate of #45802? Can you please check if the fix in golang.org/x/tools/gopls@v0.7.1-pre.1 meets what you want?

[soypat]

@hyangah negative. The issues are similar in nature though. I'm not asking for literal evaluation but rather that gopls show me how the author initialized a const integer since there are around 5 ways of initializing the same number and usually non-decimal form carries useful information about certain bits (i.e. bitfields, masks)

[gopherbot]

Change https://golang.org/cl/381961 mentions this issue: internal/lsp/source: show an original declaration and a value for variables and constants