ssh: add support for extension negotiation (rfc 8308) by drakkan · Pull Request #211 · golang/crypto

drakkan · 2022-03-30T10:30:51Z

This is a rebase of the following PR

with some changes and improvements:

added support for client certificate authentication
removed read loop from server handshake
adapted extInfoMsg to upstream changes

Signed-off-by: Nicola Murino nicola.murino@gmail.com

This is a rebase of the following PR #197 with some changes and improvements: - added support for client certificate authentication - removed read loop from server handshake - adapted extInfoMsg to upstream changes Signed-off-by: Nicola Murino <nicola.murino@gmail.com>

gopherbot · 2022-03-30T10:31:37Z

This PR (HEAD: 7fe3443) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/crypto/+/396714 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

always add ext-info-s to KEX and send the SSH_MSG_EXT_INFO message if we received ext-info-c from the client Signed-off-by: Nicola Murino <nicola.murino@gmail.com>

gopherbot · 2022-03-30T11:53:07Z

This PR (HEAD: 0196e38) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/crypto/+/396714 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

Signed-off-by: Nicola Murino <nicola.murino@gmail.com>

gopherbot · 2022-03-30T14:07:37Z

This PR (HEAD: 2b41359) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/crypto/+/396714 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

we already know if this is the first key exchange Signed-off-by: Nicola Murino <nicola.murino@gmail.com>

gopherbot · 2022-03-30T15:01:26Z

This PR (HEAD: 4929d4a) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/crypto/+/396714 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

we need it for both client and server Signed-off-by: Nicola Murino <nicola.murino@gmail.com>

gopherbot · 2022-03-30T15:06:21Z

This PR (HEAD: 76c9400) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/crypto/+/396714 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

Signed-off-by: Nicola Murino <nicola.murino@gmail.com>

gopherbot · 2022-03-31T09:03:42Z

This PR (HEAD: 5835f04) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/crypto/+/396714 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2022-03-31T09:12:02Z

Message from Nicola Murino:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/396714.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-05-18T18:26:58Z

Message from Stan Hu:

Patch Set 6:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/396714.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-05-18T18:31:55Z

Message from Stan Hu:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/396714.
After addressing review feedback, remember to publish your drafts!

both client and server side need to parse this message Signed-off-by: Nicola Murino <nicola.murino@gmail.com>

gopherbot · 2022-05-19T15:04:08Z

This PR (HEAD: 92ea34e) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/crypto/+/396714 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2022-05-19T15:12:58Z

Message from Nicola Murino:

Patch Set 7:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/396714.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-06-14T23:19:45Z

Message from Stan Hu:

Patch Set 7:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/396714.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-06-15T04:06:10Z

Message from Stan Hu:

Patch Set 7:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/396714.
After addressing review feedback, remember to publish your drafts!

Signed-off-by: Nicola Murino <nicola.murino@gmail.com>

gopherbot · 2022-06-15T08:09:23Z

This PR (HEAD: 8cff989) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/crypto/+/396714 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2022-06-15T08:13:35Z

Message from Nicola Murino:

Patch Set 7:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/396714.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-06-15T19:21:31Z

Message from Stan Hu:

Patch Set 8:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/396714.
After addressing review feedback, remember to publish your drafts!

r0mant · 2022-08-02T20:18:42Z

Hello, is there any ETA on when this PR will merge? Thanks.

ianlancetaylor · 2022-08-03T00:01:55Z

@r0mant Please don’t reply on this GitHub thread. Visit golang.org/cl/396714. Thanks.

gopherbot · 2022-09-13T17:24:21Z

Message from Michał Trojnara:

Patch Set 8:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/396714.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-09-14T14:05:48Z

Message from Nicola Murino:

Patch Set 8:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/396714.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-09-14T15:40:19Z

Message from Michał Trojnara:

Patch Set 8:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/396714.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-09-14T16:27:59Z

Message from Nicola Murino:

Patch Set 8:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/396714.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-09-15T11:32:30Z

Message from Filippo Valsorda:

Patch Set 8:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/396714.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-09-15T17:46:11Z

Message from Nicola Murino:

Patch Set 8:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/396714.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-11-03T18:27:47Z

Message from Filippo Valsorda:

Patch Set 8:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/396714.
After addressing review feedback, remember to publish your drafts!

reedloden · 2023-01-23T18:22:09Z

@drakkan Did this get addressed upstream?

brodock · 2023-03-01T14:02:46Z

@reedloden doesn't seem like it was.

stanhu · 2023-05-03T21:34:09Z

Actually, it did. https://go.dev/cl/447757 was merged in November 2022 and pared down this pull request: golang/go#49269 (comment).

I don't think we need to support ext-info-s either since this causes the client to send SSH_MSG_EXT_INFO, and this pull request just read and threw away the message.

remove the Extension setting

0196e38

always add ext-info-s to KEX and send the SSH_MSG_EXT_INFO message if we received ext-info-c from the client Signed-off-by: Nicola Murino <nicola.murino@gmail.com>

add ext-info-s to KEX algorithms only in the first key exchange

2b41359

Signed-off-by: Nicola Murino <nicola.murino@gmail.com>

remove extInfoSent field

4929d4a

we already know if this is the first key exchange Signed-off-by: Nicola Murino <nicola.murino@gmail.com>

sendKexInit: evaluate first key exchange only once

76c9400

we need it for both client and server Signed-off-by: Nicola Murino <nicola.murino@gmail.com>

improve code comments

5835f04

Signed-off-by: Nicola Murino <nicola.murino@gmail.com>

added a shared method to parse extInfoMsgs

92ea34e

both client and server side need to parse this message Signed-off-by: Nicola Murino <nicola.murino@gmail.com>

send server-sig-algs using the same order as OpenSSH

8cff989

Signed-off-by: Nicola Murino <nicola.murino@gmail.com>

russjones mentioned this pull request Aug 3, 2022

Drop support for SHA1 gravitational/teleport#15149

Closed

iQQBot mentioned this pull request Aug 5, 2022

ssh: add support for extension negotiation (rfc 8308) gitpod-io/golang-crypto#2

Closed

This was referenced Aug 22, 2022

ssh: add support for extension negotiation (rfc 8308) gitpod-io/golang-crypto#3

Merged

Some Open SSH and RSA key versions are not compatible with Gitpod SSH Gateway gitpod-io/gitpod#12287

Closed

FiloSottile mentioned this pull request Nov 3, 2022

x/crypto/ssh: rsa-sha2-256/rsa-sha2-512 tracking issue golang/go#49952

Open

7 tasks

This was referenced Dec 30, 2022

SSH SHA-256 key not accepted argoproj/argo-cd#7600

Open

Git SSH keys failing to authenticate argoproj/argo-cd#9122

Open

drakkan closed this Jan 23, 2023

drakkan deleted the rfc8308 branch January 23, 2023 15:27

Conversation

drakkan commented Mar 30, 2022

Uh oh!

gopherbot commented Mar 30, 2022

Uh oh!

gopherbot commented Mar 30, 2022

Uh oh!

gopherbot commented Mar 30, 2022

Uh oh!

gopherbot commented Mar 30, 2022

Uh oh!

gopherbot commented Mar 30, 2022

Uh oh!

gopherbot commented Mar 31, 2022

Uh oh!

gopherbot commented Mar 31, 2022

Uh oh!

gopherbot commented May 18, 2022

Uh oh!

gopherbot commented May 18, 2022

Uh oh!

gopherbot commented May 19, 2022

Uh oh!

gopherbot commented May 19, 2022

Uh oh!

gopherbot commented Jun 14, 2022

Uh oh!

gopherbot commented Jun 15, 2022

Uh oh!

gopherbot commented Jun 15, 2022

Uh oh!

gopherbot commented Jun 15, 2022

Uh oh!

gopherbot commented Jun 15, 2022

Uh oh!

r0mant commented Aug 2, 2022

Uh oh!

ianlancetaylor commented Aug 3, 2022

Uh oh!

gopherbot commented Sep 13, 2022

Uh oh!

gopherbot commented Sep 14, 2022

Uh oh!

gopherbot commented Sep 14, 2022

Uh oh!

gopherbot commented Sep 14, 2022

Uh oh!

gopherbot commented Sep 15, 2022

Uh oh!

gopherbot commented Sep 15, 2022

Uh oh!

gopherbot commented Nov 3, 2022

Uh oh!

reedloden commented Jan 23, 2023

Uh oh!

brodock commented Mar 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

stanhu commented May 3, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

brodock commented Mar 1, 2023 •

edited

Loading