Skip to content

Update VERSION_HISTORY.md and MIGRATION_GUIDE.md #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 8, 2021

Conversation

oxisto
Copy link
Collaborator

@oxisto oxisto commented Jun 4, 2021

Fixes #25

@oxisto
Copy link
Collaborator Author

oxisto commented Jun 4, 2021

@mfridman I think you had a suggesting for replacements before, would you mind adding that here? something like

go mod edit -replace github.com/dgrijalva/jwt-go=github.com/golang-jwt/[email protected]+incompatible

But will that work with our new import path? Or should we provide some sed-style replacement command?

Edit. I have just testing it with go mod edit -replace github.com/dgrijalva/jwt-go=github.com/golang-jwt/[email protected], which already has the new import path, works with problems

@oxisto oxisto marked this pull request as ready for review June 4, 2021 18:45
@oxisto oxisto force-pushed the version-and-migration-update branch 2 times, most recently from 087fe48 to 96bc4ec Compare June 4, 2021 18:55
@oxisto oxisto requested review from Waterdrips and mfridman June 4, 2021 18:56
@oxisto oxisto force-pushed the version-and-migration-update branch from 96bc4ec to aa2d0fc Compare June 4, 2021 18:57
Copy link
Member

@mfridman mfridman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. I see the backwards-compatibility was mentioned in the README so that's good enough.

@oxisto oxisto merged commit 5130b59 into main Jun 8, 2021
@oxisto oxisto deleted the version-and-migration-update branch June 8, 2021 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update MIGRATION_GUIDE and VERSION_HISTORY
2 participants