diff: capture both old and new of index and mode #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
unknwon
requested changes
Mar 24, 2022
aymanbagabas
force-pushed
the
diff-file
branch
2 times, most recently
from
bcec7eb to
d16f88e
Compare
|
GitHub Actions did not pick up, I'll close and re-open to trigger it again. |
unknwon
reviewed
Mar 25, 2022
unknwon
reviewed
Mar 25, 2022
|
Thanks for the followup! Overall LGTM, asked few remaining questions :) |
This adds some missing information needed to constructe a full-index diff from DiffFile struct type. It adds old/new file mode, index, and name.
unknwon
reviewed
Mar 26, 2022
unknwon
approved these changes
Mar 26, 2022
unknwon
changed the title
|
https://github.com/gogs/git-module/releases/tag/v1.5.0 has been tagged for this merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some missing information needed to constructe a full-index
diff from DiffFile struct type. It adds old/new file mode, index, and
name.