Skip to content

repo_tag: able to list tags using sort and filter options #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 14, 2022

Conversation

sermojohn
Copy link
Contributor

No description provided.

@sermojohn sermojohn changed the title feat: tag list using sort and filter options tag list using sort and filter options Mar 14, 2022
@sermojohn sermojohn changed the title tag list using sort and filter options tag: list using sort and filter options Mar 14, 2022
@sermojohn sermojohn changed the title tag: list using sort and filter options Tag list using sort and filter options Mar 14, 2022
@unknwon unknwon self-requested a review March 14, 2022 13:52
Copy link
Member

@unknwon unknwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Overall looks good, left few comments.

Comment on lines +147 to +150
// SortKet sorts tags with provided tag key, optionally prefixed with '-' to sort tags in descending order.
SortKey string
// Pattern filters tags matching the specified pattern.
Pattern string
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move these options up before the Timeout.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 03e73ec

Copy link
Member

@unknwon unknwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the followup!

@unknwon unknwon changed the title Tag list using sort and filter options repo_tag: able to list tags using sort and filter options Mar 14, 2022
@unknwon unknwon merged commit 5028c0a into gogs:master Mar 14, 2022
@unknwon
Copy link
Member

unknwon commented Mar 14, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants