Skip to content

repo_tag: able to create annotated tag #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 15, 2022
Merged

repo_tag: able to create annotated tag #70

merged 4 commits into from
Mar 15, 2022

Conversation

sermojohn
Copy link
Contributor

No description provided.

@sermojohn sermojohn changed the title tag: create annotated tag Create annotated tag Mar 14, 2022
@unknwon
Copy link
Member

unknwon commented Mar 14, 2022

Thanks for the PR! Looks like the CI is not passing :)

@unknwon unknwon self-requested a review March 14, 2022 13:52
@sermojohn
Copy link
Contributor Author

Thanks for the PR! Looks like the CI is not passing :)

Good catch by the CI, specifying no committer for annotated tags fails the command.
Maybe explicitly ignoring the local global config would help identifying this issue.
Here is an example how I could effectively enforce ingoring the global config from my system:

GIT_CONFIG_GLOBAL=".noconfig" git commit --allow-empty -m ""

Author identity unknown

*** Please tell me who you are.
...

unknwon
unknwon requested changes Mar 15, 2022
View reviewed changes
Copy link
Member

@unknwon unknwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the follow up!

@sermojohn sermojohn requested a review from unknwon March 15, 2022 09:25
unknwon
unknwon approved these changes Mar 15, 2022
View reviewed changes
Copy link
Member

@unknwon unknwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

repo_tag.go
cmd := NewCommand("tag")
if opt.Annotated {
cmd.AddArgs("-a", name)
cmd.AddArgs("--message", opt.Message)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised this actually works without error.

@unknwon unknwon changed the title Create annotated tag repo_tag: able to create annotated tag Mar 15, 2022
@unknwon unknwon merged commit 93f85f8 into gogs:master Mar 15, 2022
@unknwon
Copy link
Member

unknwon commented Mar 15, 2022

https://github.com/gogs/git-module/releases/tag/v1.4.0 has been tagged for this merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unknwon unknwon unknwon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sermojohn @unknwon