Skip to content

Add a property range hint to bake_fps in the scene glTF export dialog #98268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 20, 2025
Merged

Add a property range hint to bake_fps in the scene glTF export dialog #98268

merged 1 commit into from
Sep 20, 2025
+2 −2

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Oct 17, 2024

This clamps the value to a value greater than 0 (exclusive).

@Calinou
Add a property range hint to bake_fps in the scene glTF export dialog
54995d9 
This clamps the value to a value greater than `0` (exclusive).
@Calinou Calinou requested review from a team as code owners October 17, 2024 15:01
@Calinou Calinou added this to the 4.4 milestone Oct 17, 2024
fire
fire approved these changes Oct 17, 2024
View reviewed changes
Copy link
Member

@fire fire left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sound good. Confirming it's 0 to 120 at intervals of 0.001 with arbitrary user input > 0. Also want to avoid divide by 0.

@Repiteo Repiteo modified the milestones: 4.4, 4.x Feb 24, 2025
@Repiteo Repiteo modified the milestones: 4.x, 4.6 Sep 20, 2025
@Repiteo Repiteo merged commit e15210b into godotengine:master Sep 20, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Sep 20, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fire fire fire approved these changes

Assignees
No one assigned
Labels
enhancement topic:editor topic:export topic:3d
Projects
None yet
Milestone
4.6
Development

Successfully merging this pull request may close these issues.
3 participants
@Calinou @Repiteo @fire