[CI] Upload build cache before running tests #94314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
commented
Jul 13, 2024
| uses: actions/cache/save@v4 | ||
| with: | ||
| path: ${{inputs.scons-cache}} | ||
| key: ${{inputs.cache-name}}-${{env.GODOT_BASE_BRANCH}}-${{github.ref}}-${{github.sha}} |
There was a problem hiding this comment.
Skipped the restore-keys here as we're not restoring from any possible keys just exactly this one
AThousandShips
force-pushed
the
cache_improve
branch
from
c22e8c5 to
89c57cd
Compare
Repiteo
approved these changes
Jul 13, 2024
|
Can't be easily cherry picked for 4.2 so will make a dedicated commit for that if this is merged, and one for 3.x, if desired |
This improves turnaround time on large PRs where compilation is successful but unit testing or similar fails, forcing recompilation of unchanged code
AThousandShips
force-pushed
the
cache_improve
branch
from
89c57cd to
32f8292
Compare
|
Moved the upload immediately after the compile step as it only involves the SCons cache |
AThousandShips
added
cherrypick:3.x
AThousandShips
added
cherrypick:3.5
akien-mga
approved these changes
Jul 17, 2024
|
Thanks! |
|
Thank you! |
AThousandShips
removed
cherrypick:3.x
This was referenced Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves turnaround time on large PRs where compilation is successful but unit testing or similar fails, forcing recompilation of unchanged code
Unsure what exactly should be part of the upload but placed the save step after the artifact prepare step and before the upload step to hopefully upload as identically as possible, assuming the artifact preparation might make for a better artifact with striping down, unsure what exactly is uploaded (it seems only the
.scons-cacheis uploaded, so might be able to move it earlier as the cache isn't touched by other steps)This was a source of friction for me making some PRs where the compilation worked fine, but the changes were relatively substantial and unit tests kept failing on Linux builds due to sanitizer errors, being unable to run those locally I ended up having to run a few CI builds to try and fix it and since they had to be recompiled from scratch (or rather from
master) it took longer than it could have, hence this PR