-
-
Notifications
You must be signed in to change notification settings - Fork 23.3k
Rework icons of noise-related classes #80427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework icons of noise-related classes #80427
Conversation
0d2a3c1
to
014b622
Compare
After asking for some feedback, I'll do another iteration where I just flip the noise pattern upside down to not resemble a smiley. |
014b622
to
f42ffe5
Compare
f42ffe5
to
127f9d0
Compare
Implemented Geometror's suggestion, also it should improve how the icons get rasterized. |
54f06a0
to
7c4c029
Compare
You should mention in your commit message that you also modify the gradient texture icons. (and maybe add an updated screenshot to the PR's description so that everyone can quickly view the changes since GH's SVG diff view unfortunately is not useful here due to lacking a dark background) |
7c4c029
to
7b37c0e
Compare
May I poke in? How do we feel about this? |
I myself feel pretty good about it now. I haven't seen how the current version of the SVG renderer handles them and if there are any changes. |
I am completely fine with this, too. I don't know who could have the final saying, however. I wouldn't want this to be stalled for ages. |
7b37c0e
to
b5d42f0
Compare
The static checks failed for a very stupid reason and the PR needs to be adjusted |
Hmm okay, I don't like how the new checks are picky about attribute order. |
It's not that, you have merge conflict markers in your icons you need to remove |
Yeah I noticed that I missed to fix merge conflicts of gradient files, but I think it's both things. Will address now |
Have you set up the pre-commit on your computer? These should be covered by the optimizations |
6440285
to
f5663a5
Compare
Nope, I haven't. Although, I'm confirming now that attribute order in SVG matters for passing the style checks. |
f5663a5
to
b061f91
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally (rebased on top of master
8ed125b), it works as expected.
Default | Light |
---|---|
![]() |
![]() |
b061f91
to
857f47e
Compare
Unsure of whose reception this needs to have to be even considered for merging |
Thanks! |
The idea was to match the designs with a set of classes that are in a pretty similar relationship:
So what do you think? I think they look quiet noise.
Noise: It's an abstract, dimension-agnostic class, it has functions to sample 1D through 3D. So the icon references a noise function.
FastNoiseLite: Similar design to Gradient, but with the classical noise jumble we all know and love. I think if you know about 2D noise, you should instantly recognize this class is about that. Also, this noise library doesn't have you think much about 1D.
NoiseTexture2D: Same idea, but may be a bit less obvious because there's only 9x7 space to communicate the idea.
NoiseTexture3D: Same idea, but again may be a bit less obvious, as now the space is only 7.75x6 so the noise pattern is even more squished.