Skip to content

Conversation

MewPurPur
Copy link
Contributor

@MewPurPur MewPurPur commented Aug 8, 2023

image

The idea was to match the designs with a set of classes that are in a pretty similar relationship:

image

So what do you think? I think they look quiet noise.

Noise: It's an abstract, dimension-agnostic class, it has functions to sample 1D through 3D. So the icon references a noise function.

FastNoiseLite: Similar design to Gradient, but with the classical noise jumble we all know and love. I think if you know about 2D noise, you should instantly recognize this class is about that. Also, this noise library doesn't have you think much about 1D.

NoiseTexture2D: Same idea, but may be a bit less obvious because there's only 9x7 space to communicate the idea.

NoiseTexture3D: Same idea, but again may be a bit less obvious, as now the space is only 7.75x6 so the noise pattern is even more squished.

@MewPurPur MewPurPur requested a review from a team as a code owner August 8, 2023 18:13
@AThousandShips AThousandShips added this to the 4.x milestone Aug 8, 2023
@MewPurPur
Copy link
Contributor Author

MewPurPur commented Aug 8, 2023

Current icons for reference

image

@MewPurPur
Copy link
Contributor Author

image

New take. It addresses a common concern that the icons were easily confused with GradientTexture2D. I'm pushing this.

@MewPurPur MewPurPur force-pushed the rework-noise-texture-icons branch 2 times, most recently from 0d2a3c1 to 014b622 Compare August 23, 2023 15:13
@MewPurPur
Copy link
Contributor Author

After asking for some feedback, I'll do another iteration where I just flip the noise pattern upside down to not resemble a smiley.

@MewPurPur
Copy link
Contributor Author

MewPurPur commented Aug 24, 2023

Take 4:

image

I think it looks excellent now!

The only icon that's a different concept from what users are familiar in 4.1 is NoiseTexture2D, and I have to mention that that icon was also not used in 4.0 by accident.

@MewPurPur MewPurPur force-pushed the rework-noise-texture-icons branch from 014b622 to f42ffe5 Compare August 24, 2023 16:27
@MewPurPur MewPurPur force-pushed the rework-noise-texture-icons branch from f42ffe5 to 127f9d0 Compare January 4, 2024 18:49
@MewPurPur
Copy link
Contributor Author

MewPurPur commented Jan 4, 2024

Implemented Geometror's suggestion, also it should improve how the icons get rasterized.

@MewPurPur MewPurPur force-pushed the rework-noise-texture-icons branch 2 times, most recently from 54f06a0 to 7c4c029 Compare January 4, 2024 21:54
@Geometror
Copy link
Member

Geometror commented Jan 11, 2024

You should mention in your commit message that you also modify the gradient texture icons. (and maybe add an updated screenshot to the PR's description so that everyone can quickly view the changes since GH's SVG diff view unfortunately is not useful here due to lacking a dark background)

@MewPurPur
Copy link
Contributor Author

MewPurPur commented Jan 17, 2024

image

Real size:

lmofa

Big rasterized pic:

image

I might have to open an issue in ThorVG about it, there's still confused rasterization.

@MewPurPur MewPurPur force-pushed the rework-noise-texture-icons branch from 7c4c029 to 7b37c0e Compare January 17, 2024 10:47
@Mickeon
Copy link
Member

Mickeon commented Feb 16, 2024

May I poke in? How do we feel about this?

@MewPurPur
Copy link
Contributor Author

MewPurPur commented Feb 16, 2024

I myself feel pretty good about it now. I haven't seen how the current version of the SVG renderer handles them and if there are any changes.

@Mickeon
Copy link
Member

Mickeon commented Feb 16, 2024

I am completely fine with this, too. I don't know who could have the final saying, however. I wouldn't want this to be stalled for ages.

@MewPurPur MewPurPur force-pushed the rework-noise-texture-icons branch from 7b37c0e to b5d42f0 Compare September 28, 2024 09:29
@MewPurPur MewPurPur requested a review from a team as a code owner September 28, 2024 09:29
@Mickeon
Copy link
Member

Mickeon commented Sep 28, 2024

The static checks failed for a very stupid reason and the PR needs to be adjusted

@MewPurPur
Copy link
Contributor Author

Hmm okay, I don't like how the new checks are picky about attribute order.

@AThousandShips
Copy link
Member

It's not that, you have merge conflict markers in your icons you need to remove

@MewPurPur
Copy link
Contributor Author

MewPurPur commented Sep 28, 2024

Yeah I noticed that I missed to fix merge conflicts of gradient files, but I think it's both things. Will address now

@AThousandShips
Copy link
Member

Have you set up the pre-commit on your computer? These should be covered by the optimizations

@MewPurPur MewPurPur force-pushed the rework-noise-texture-icons branch 2 times, most recently from 6440285 to f5663a5 Compare September 28, 2024 13:08
@MewPurPur
Copy link
Contributor Author

Nope, I haven't. Although, I'm confirming now that attribute order in SVG matters for passing the style checks.

@MewPurPur MewPurPur force-pushed the rework-noise-texture-icons branch from f5663a5 to b061f91 Compare September 28, 2024 13:17
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally (rebased on top of master 8ed125b), it works as expected.

Default Light
image image

@MewPurPur MewPurPur force-pushed the rework-noise-texture-icons branch from b061f91 to 857f47e Compare April 5, 2025 15:46
@Mickeon
Copy link
Member

Mickeon commented Apr 5, 2025

Unsure of whose reception this needs to have to be even considered for merging

@Repiteo Repiteo modified the milestones: 4.x, 4.6 Sep 19, 2025
@Repiteo Repiteo merged commit 2a7e01e into godotengine:master Sep 19, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Sep 19, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants