Skip to content

Allow GDExtension to register unexposed classes. #69653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Daylily-Zeleen
Copy link
Contributor

@Daylily-Zeleen Daylily-Zeleen commented Dec 6, 2022

Relate to #951.

It seems that some register methods are redundant. I am not sure about that, these new register methods just for making style consistent.

@Daylily-Zeleen Daylily-Zeleen marked this pull request as ready for review December 6, 2022 11:42
@Daylily-Zeleen Daylily-Zeleen requested review from a team as code owners December 6, 2022 11:42
@Daylily-Zeleen
Copy link
Contributor Author

How to deal godot-cpp test check error?

@Daylily-Zeleen
Copy link
Contributor Author

I don't know this issue is relate on the check failed or not:
gdnative_interface_dump.gen.h will not be auto regenerate if gdnative_interface.h changed.
@groud , I see the commit history mention you, can you give me some suggestions to solve this problem?

@groud
Copy link
Member

groud commented Dec 7, 2022

I don't know this issue is relate on the check failed or not: gdnative_interface_dump.gen.h will not be auto regenerate if gdnative_interface.h changed. @groud , I see the commit history mention you, can you give me some suggestions to solve this problem?

Well, you need to compile again and it should work. See this code , the gdnative_interface.h is correctly being listed as a source file.

@Daylily-Zeleen
Copy link
Contributor Author

I don't know this issue is relate on the check failed or not: gdnative_interface_dump.gen.h will not be auto regenerate if gdnative_interface.h changed. @groud , I see the commit history mention you, can you give me some suggestions to solve this problem?

Well, you need to compile again and it should work. See this code , the gdnative_interface.h is correctly being listed as a source file.

I generate a new gdnative_interface.h file and replace the godot/core/extension/gdnative_interface.h, but noting change, I means that I already modified it and same as the generated version.

So...how can I slove the check failed?

@akien-mga
Copy link
Member

The godot-cpp change would need to be merged first, then this PR rebased, so it can pass CI.

@Daylily-Zeleen
Copy link
Contributor Author

The godot-cpp change would need to be merged first, then this PR rebased, so it can pass CI.

Thanks for your repay, I just afraid that the error is because of my mistake.

@Daylily-Zeleen
Copy link
Contributor Author

Replace by #70329.

@Daylily-Zeleen Daylily-Zeleen deleted the daylily-zeleen/allow_gde_regisiter_unexposed_classes branch December 20, 2022 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants