Fix uneditable TextEdit draws both normal and read_only styles together #110527
+90
−109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WhalesState
changed the title
This comment was marked as resolved.
This comment was marked as resolved.
AThousandShips
added
bug
topic:gui
cherrypick:4.5
WhalesState
force-pushed
the
text-edit-styles
branch
from
272c6d9 to
56c8902
Compare
WhalesState
force-pushed
the
text-edit-styles
branch
2 times, most recently
from
d3715de to
9c145d1
Compare
This was referenced Sep 21, 2025
WhalesState
commented
Sep 21, 2025
|
|
||
| int visible_width = get_size().width - theme_cache.style_normal->get_minimum_size().width - gutters_width - gutter_padding; | ||
| Ref<StyleBox> style = _get_current_stylebox(); | ||
| int visible_width = get_size().width - Math::ceil(style->get_margin(SIDE_LEFT)) - Math::floor(style->get_margin(SIDE_RIGHT)) - gutters_width - gutter_padding; |
There was a problem hiding this comment.
This change fixes the issue where the last character was cut off when the editor scale is a fractional number. Previously, we used style->get_minimum_size().width, but draw methods always round up the left and right style margins with Math::ceil, which caused a mismatch.
WhalesState
commented
Sep 21, 2025
WhalesState
force-pushed
the
text-edit-styles
branch
from
9c145d1 to
a9881bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.