Use language command line argument to override editor locale.
#110318
+20
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
reviewed
Sep 8, 2025
There was a problem hiding this comment.
Tested locally, it works as expected. Code looks good to me.
However, the CLI argument doesn't carry over from the project manager to the editor, while I would expect it to. (I don't expect it to carry over from the project manager to the running project when using Run though.)
Calinou
added
topic:i18n
cherrypick:4.5
|
This can be fixed with |
|
KoBeWi
approved these changes
Sep 9, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
languageargument was used for running projects, but was completely ignored by editor/pm. Argument is only applied during initial load and is not used when changing locale from the editor settings.Fixes #110273