AudioStreamOggVorbis: only show invalid comment warning in Editor builds #109844
+6
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronfranke
reviewed
Aug 22, 2025
|
https://xiph.org/vorbis/doc/v-comment.html Basically, comments are structured like env vars in vorbis, |
|
@nikitalita Can you put that in a comment in the code? |
nikitalita
force-pushed
the
invalid-ogg-comment
branch
from
be19b86 to
df7c7d8
Compare
|
done |
aaronfranke
reviewed
Aug 23, 2025
aaronfranke
approved these changes
Aug 23, 2025
nikitalita
force-pushed
the
invalid-ogg-comment
branch
from
3ab7490 to
9aa9bac
Compare
|
I can't re-run the failed jobs |
|
I think this is ready to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a bunch of music editors love to set invalid Vorbis comments in ogg vorbis files that they export (e.g. Sony's likes to write "Sony Ogg Vorbis 1.0 Final"), and this results in a lot of logspam whenever an ogg like this is loaded up. We should really only be emitting a warning about it if tools are enabled.