Skip to content

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Jul 27, 2025

Fixes #109028

Screen.Recording.2025-07-27.at.21.29.17.mov

@bruvzg bruvzg added this to the 4.6 milestone Jul 27, 2025
@bruvzg bruvzg requested a review from a team as a code owner July 27, 2025 18:29
@AThousandShips AThousandShips changed the title Include SPACING_SPACE into tab stops calculation. Include SPACING_SPACE in tab stops calculation. Jul 28, 2025
@sydist
Copy link

sydist commented Jul 30, 2025

Awesome I didn't expect this to get a PR so quickly, well done!
Does this affect tab stops size in regular labels by chance?

Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, it works as expected. Code looks good to me.

Testing project: test_pr_109031.zip

Labels on top don't have extra spacing, while the ones at the bottom have 10 pixels per space:

image

@Repiteo Repiteo merged commit 2c1ad5b into godotengine:master Sep 19, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Sep 19, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changing the space size in FontVariation does not change the size of the tabs
4 participants