Skip to content

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Jul 3, 2025

Applies the new PROPERTY_HINT_GROUP_ENABLE to more properties.

@KoBeWi KoBeWi added this to the 4.x milestone Jul 3, 2025
@KoBeWi KoBeWi requested review from a team as code owners July 3, 2025 20:31
@KoBeWi KoBeWi force-pushed the ENABLE_HINT_GROUP_PROPERTY_HINT branch 3 times, most recently from 571a5bc to 1661923 Compare July 3, 2025 21:11
Copy link
Member

@rburing rburing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me.

@Ivorforce
Copy link
Member

I've adding this to the 4.6 merge queue since it's an enhancement. But feel free to change if you see this going into 4.5 yet.

@timothyqiu
Copy link
Member

Decal, Sprite{2D,3D}, and VisualShader used _validate_property() to hide related properties before. Those logic redundant now and can be removed.

@KoBeWi KoBeWi force-pushed the ENABLE_HINT_GROUP_PROPERTY_HINT branch from 1661923 to 7a13790 Compare July 4, 2025 10:05
@KoBeWi
Copy link
Member Author

KoBeWi commented Jul 7, 2025

Looks like there is failed check in a class I didn't modify?

@Repiteo
Copy link
Contributor

Repiteo commented Sep 20, 2025

Rebase just in case; I assume that was a fluke

@KoBeWi KoBeWi force-pushed the ENABLE_HINT_GROUP_PROPERTY_HINT branch from 7a13790 to 79ecc16 Compare September 20, 2025 15:48
@Repiteo
Copy link
Contributor

Repiteo commented Sep 20, 2025

Did some local testing & it looks like removing _validate_property from Decal was the culprit. Perhaps that should be reimplemented, but with just the || p_property.name == "distance_fade_length" conditional removed? Or the logic they previously hid should be integrated directly, if possible

@KoBeWi KoBeWi force-pushed the ENABLE_HINT_GROUP_PROPERTY_HINT branch from 79ecc16 to 98a4b46 Compare September 20, 2025 19:11
@KoBeWi KoBeWi requested a review from a team as a code owner September 20, 2025 19:11
@KoBeWi
Copy link
Member Author

KoBeWi commented Sep 20, 2025

Seems to me that sorting_offset is not supposed to have default value in VisualInstance3D. It's even defined incorrectly, the binding uses DEFAULT usage, but then overwrites it in _validate_property() unconditionally 🤦‍♂️

I went ahead and fixed it.

@Repiteo Repiteo modified the milestones: 4.x, 4.6 Sep 20, 2025
@Repiteo Repiteo merged commit ba0da90 into godotengine:master Sep 22, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Sep 22, 2025

Thanks!

@KoBeWi KoBeWi deleted the ENABLE_HINT_GROUP_PROPERTY_HINT branch September 22, 2025 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants